Also think of something like VS Code SSH remote sessions. That's not always the case □(!) Developers should be allowed to SSH in to a macOS machine, imagine SSH-ing in to a headless Mac mini build machine for example (I have done this myself in previous job!). Nevertheless, I think that maybe GCM could assume that macOS always has desktop capability, since it should be pretty uncommon that developers run macOS in headless mode. Linux), we use the presence of the $DISPLAY variable. We actually use GetProcessWindowStation() and GetUserObjectInformation() on Windows, and SessionGetInfo() on macOS to detect the presence of a GUI environment. Whether you see the 'web browser' option depends on the DISPLAY environment variable Īh, I see! DISPLAY isn't set for me on macOS, where I would guess that this variable is never set by default ![]() When nothing is set for credential.gitHubAuthModes we show a prompt asking the user to pick the flow that suits them. ![]() Should I open another thread to ask this in? GCM is detecting this is and should be presenting all possible auth options available (interactive via browser, manually generated PAT, OAuth device code flow).Īt the risk of derailing the original topic in this thread, my question is whether I should expect that Device flow is auto-detected as a default authentication method for when nothing is set as credential.gitHubAuthModes (i.e. My next question is, why hasn't GCM auto-detected this when authorizing a git operation from, but instead it defaulted to OAuth web app flow? I would argue that the Device flow should be the default and that it's straightforward to feature-detect. That's why I was talking so much about device flow in this thread sure, you could spend time improving the HTTP redirect experience, but a much better long-term solution is to avoid the local server redirect altogether. If you'd want help with that, I'm sure we could extend the feature to your OAuth app as well: just email me at it's even a better idea to default to device flow whenever possible instead of the web application flow. ![]() This relied on a feature that's not public. Going back to the original topic: in GitHub CLI, which also used to authorize over OAuth web application flow, we've migrated from callback to in a way that's backwards-compatible, using the same OAuth app. Whether you see the 'web browser' option depends on the DISPLAY environment variableĪh, I see! DISPLAY isn't set for me on macOS, where I would guess that this variable is never set by default.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |